Skip to content

chore(deps): remove dependency on github.com/pkg/errors #2184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 7, 2025
Merged

chore(deps): remove dependency on github.com/pkg/errors #2184

merged 3 commits into from
Apr 7, 2025

Conversation

hazzik
Copy link
Contributor

@hazzik hazzik commented Mar 27, 2025 •
edited
Loading

Description

Remove dependency on github.com/pkg/errors as it was archived

Checklist

  • Code compiles correctly and linting passes locally
  • For all code changes, an entry added to the CHANGELOG.md file describing and linking to
    this PR
  • Tests added for new functionality, or regression tests for bug fixes added as applicable
  • For public APIs, new features, etc., PR on docs repo
    staged and linked here

Instructions

  • The PR title should follow the Conventional Commits
    syntax, leading with fix:, feat:, chore:, ci:, etc.
  • The description should briefly explain what the PR is about. In the case of a bugfix, describe or
    link to the bug.
  • In the checklist section, check the boxes in that are applicable, using [x] syntax.
    • If not applicable, remove the entire line. Only leave the box unchecked if you intend to come
      back and check the box later.
  • Delete the Instructions line and everything below it, to indicate you have read and are
    following these instructions. 🙂

Thank you for your contribution to Badger!

@Copilot Copilot AI review requested due to automatic review settings March 27, 2025 14:22
@hazzik hazzik requested a review from a team as a code owner March 27, 2025 14:22
Copilot
Copilot AI reviewed Mar 27, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the dependency on github.com/pkg/errors and updates error creation and wrapping accordingly throughout the codebase. Key changes include replacing errors.Errorf and errors.Wrapf with fmt.Errorf and errors.New, and removing the import of github.com/pkg/errors.

Reviewed Changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated no comments.

Show a summary per file
File Description
value.go Replaced pkg/errors usage with built-in errors and fmt.Errorf
util.go Removed pkg/errors import; minor update to error handling
txn.go Updated error formatting and removed pkg/errors import
trie/trie.go Updated error wrapping for ignore bytes parsing
table/table.go Switched to using errors and fmt.Errorf instead of pkg/errors
table/builder.go Removed pkg/errors import and updated corresponding error handling
stream_writer.go Updated error wrapping in flatten and key order checks
publisher_test.go Removed pkg/errors import in tests
options.go Replaced pkg/errors usage with fmt.Errorf in compression parsing
memtable.go Updated error message in file existence check
manifest.go Removed pkg/errors import; updated error creation for magic/checksum errors
levels.go Replaced pkg/errors usage with errors.New in table-filling error
db.go Updated error messages and error wrapping across various checks
batch.go Replaced pkg/errors usage with fmt.Errorf in batch flushing errors
badger/cmd/stream.go Removed pkg/errors import; updated error creation for CLI validations
badger/cmd/read_bench.go Removed pkg/errors import; updated error creation in test logic
badger/cmd/info.go Removed pkg/errors import; updated error message formatting
badger/cmd/flatten.go Removed pkg/errors import; updated error creation for compression checks
backup.go Switched pkg/errors usage to fmt.Errorf for error wrapping in backup logic
Files not reviewed (1)
  • go.mod: Language not supported
Comments suppressed due to low confidence (1)

db.go:154

  • [nitpick] Consider using consistent capitalization for 'ValueThreshold' rather than 'Valuethreshold' in the error message.
return fmt.Errorf("Valuethreshold %d greater than max batch size of %d. Either "+

@hazzik hazzik changed the title chore: remove dependency on github.com/pkg/errors chore(deps): remove dependency on github.com/pkg/errors Mar 27, 2025
@mangalaman93
Copy link
Member

Thank you for the PR, why does it not remove this package from go.mod?

@hazzik
Copy link
Contributor Author

hazzik commented Apr 4, 2025

Some other dependencies still have it referenced:

% go mod graph | grep \ github.com/pkg/errors
github.com/dgraph-io/badger/v4 github.com/pkg/[email protected]
github.com/dgraph-io/ristretto/[email protected] github.com/pkg/[email protected]

Would need to update ristretto when next version is released: hypermodeinc/ristretto@a748a7f as you have renovate set up it would be done some time automatically.

@mangalaman93
Copy link
Member

We should upgrade ristretto to v2.2.0 released here https://github.com/hypermodeinc/ristretto/releases/tag/v2.2.0

@hazzik
Copy link
Contributor Author

hazzik commented Apr 4, 2025

@mangalaman93 do you want me to do it in this PR? or I can create another one with upgrade, or wait for renovate. I'm not in a rush.

@mangalaman93
Copy link
Member

This PR is fine too

@hazzik
Copy link
Contributor Author

hazzik commented Apr 4, 2025

@mangalaman93 done

@mangalaman93 mangalaman93 merged commit a9a63e2 into hypermodeinc:main Apr 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@mangalaman93 mangalaman93 mangalaman93 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hazzik @mangalaman93